aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDirk Mueller <dmueller@suse.com>2020-01-14 18:53:41 +0100
committerDavid Gibson <david@gibson.dropbear.id.au>2020-01-16 11:00:19 +1000
commit0e9225eb0dfec51def612b928d2f1836b092bc7e (patch)
tree5b5ea27592063415f92e70d6513b7833ef891d94
parentcab09eedd644cebdb4390b8b269012350d291cba (diff)
downloaddtc-0e9225eb0dfec51def612b928d2f1836b092bc7e.tar.gz
Remove redundant YYLOC global declaration
gcc 10 will default to -fno-common, which causes this error at link time: (.text+0x0): multiple definition of `yylloc'; dtc-lexer.lex.o (symbol from plugin):(.text+0x0): first defined here This is because both dtc-lexer as well as dtc-parser define the same global symbol yyloc. Before with -fcommon those were merged into one defintion. The proper solution would be to to mark this as "extern", however that leads to: dtc-lexer.l:26:16: error: redundant redeclaration of 'yylloc' [-Werror=redundant-decls] 26 | extern YYLTYPE yylloc; | ^~~~~~ In file included from dtc-lexer.l:24: dtc-parser.tab.h:127:16: note: previous declaration of 'yylloc' was here 127 | extern YYLTYPE yylloc; | ^~~~~~ cc1: all warnings being treated as errors which means the declaration is completely redundant and can just be dropped. Signed-off-by: Dirk Mueller <dmueller@suse.com> Message-Id: <20200114175341.2994-1-dmueller@suse.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--dtc-lexer.l1
1 files changed, 0 insertions, 1 deletions
diff --git a/dtc-lexer.l b/dtc-lexer.l
index 5c6c3fd..b3b7270 100644
--- a/dtc-lexer.l
+++ b/dtc-lexer.l
@@ -23,7 +23,6 @@ LINECOMMENT "//".*\n
#include "srcpos.h"
#include "dtc-parser.tab.h"
-YYLTYPE yylloc;
extern bool treesource_error;
/* CAUTION: this will stop working if we ever use yyless() or yyunput() */