aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-05-20 09:17:11 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2009-06-19 11:00:53 -0700
commita3d97c9b192df8e9c6a041f9452b400070ce2d02 (patch)
treefa30fadf622408b9ab6b0a56987c66f3bd232c27
parent562bf4845fbd9240a1964734d769bb5f6973e759 (diff)
Staging: cpc-usb: Adjust NULL test
Since card must already be non-NULL, it seems that what was intended was to test the result of kmalloc. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E,E1; identifier f,fld,fld1; statement S1,S2; @@ E->fld = f(...); ... when != E = E1 when != E->fld1 = E1 if ( - E + E->fld == NULL) S1 else S2 // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/cpc-usb/cpc-usb_drv.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/cpc-usb/cpc-usb_drv.c b/drivers/staging/cpc-usb/cpc-usb_drv.c
index 14aca39..672f786 100644
--- a/drivers/staging/cpc-usb/cpc-usb_drv.c
+++ b/drivers/staging/cpc-usb/cpc-usb_drv.c
@@ -899,7 +899,7 @@ static int cpcusb_probe(struct usb_interface *interface,
/* allocate and initialize the channel struct */
card->chan = kmalloc(sizeof(CPC_CHAN_T), GFP_KERNEL);
- if (!card) {
+ if (!card->chan) {
kfree(card);
err("Out of memory");
return -ENOMEM;