diff options
| author | Luis Chamberlain <mcgrof@kernel.org> | 2021-07-15 01:48:20 +0000 |
|---|---|---|
| committer | Luis Chamberlain <mcgrof@kernel.org> | 2021-08-17 00:04:23 -0700 |
| commit | e3939d1f567d414dd705aa8c5015396cde7f3306 (patch) | |
| tree | 8972dda05b2e0e4f087435de1eba66fb550dd284 | |
| parent | 0b32270d78abda58866cda0d165eb6e5a7b36de9 (diff) | |
| download | linux-e3939d1f567d414dd705aa8c5015396cde7f3306.tar.gz | |
ms_block: add error handling support for add_disk()
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Contrary to the typical removal which delays the put_disk()
until later, since we are failing on a probe we immediately
put the disk on failure from add_disk by using
blk_cleanup_disk().
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
| -rw-r--r-- | drivers/memstick/core/ms_block.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index 4a4573fa7b0fa..96c95f5e12218 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -2156,10 +2156,14 @@ static int msb_init_disk(struct memstick_dev *card) set_disk_ro(msb->disk, 1); msb_start(card); - device_add_disk(&card->dev, msb->disk, NULL); + rc = device_add_disk(&card->dev, msb->disk, NULL); + if (rc) + goto out_cleanup_disk; dbg("Disk added"); return 0; +out_cleanup_disk: + blk_cleanup_disk(msb->queue); out_free_tag_set: blk_mq_free_tag_set(&msb->tag_set); out_release_id: |