diff options
| author | Luis Chamberlain <mcgrof@kernel.org> | 2021-08-16 22:36:38 -0700 |
|---|---|---|
| committer | Luis Chamberlain <mcgrof@kernel.org> | 2021-08-17 00:04:22 -0700 |
| commit | b7e9e637531f1679afe287c382cfaa1af857012b (patch) | |
| tree | 9a0f97d38adf7cf48c8d56fd313901bdaa0ce6bc | |
| parent | 2c703ea3ba3cb1bf47478c015956c31c97aebdd4 (diff) | |
| download | linux-b7e9e637531f1679afe287c382cfaa1af857012b.tar.gz | |
pd: add error handling support for add_disk()
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
| -rw-r--r-- | drivers/block/paride/pd.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index 500b89a4bdaf5..f83eceef86b0b 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c @@ -938,8 +938,12 @@ static int pd_probe_drive(struct pd_unit *disk, int autoprobe, int port, if (ret) goto put_disk; set_capacity(disk->gd, disk->capacity); - add_disk(disk->gd); + ret = add_disk(disk->gd); + if (ret) + goto cleanup_disk: return 0; +cleanup_disk: + blk_cleanup_disk(disk); put_disk: put_disk(p); disk->gd = NULL; |