diff options
| author | Kees Cook <keescook@chromium.org> | 2021-06-18 23:30:07 -0700 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2022-01-24 11:51:44 -0800 |
| commit | 4ba545781e20f49cf1175e11d9f606e621040acf (patch) | |
| tree | 241f1e590820c9fe47aa63c5f192ddb5b30de5bb | |
| parent | 2cb06c87c9ddbe0801fd1d94def2e24703772224 (diff) | |
| download | linux-4ba545781e20f49cf1175e11d9f606e621040acf.tar.gz | |
Makefile: Enable -Warray-bounds
Notice: this object is not reachable from any branch.
With the recent fixes for flexible arrays and expanded FORTIFY_SOURCE
coverage, it is now possible to enable -Warray-bounds. Since both GCC
and Clang include -Warray-bounds in -Wall, adjust the Makefile to just
stop disabling it.
Note that this option can be conservative in its warnings (which is
done at casting time rather than access time), but this is reasonable
since the cast variables may be accessed out of a scope where the true
size of the original object can't be evaluated. These handful of false
positives (which are arguably bad casts and can be easily avoided),
are worth dealing with because of the many places where this option
has helped identify missed bounds checks and even accesses done against
cases where a NULL pointer could be reached.
https://github.com/KSPP/linux/issues/109
https://github.com/KSPP/linux/issues/151
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
Co-developed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Notice: this object is not reachable from any branch.
| -rw-r--r-- | Makefile | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/Makefile b/Makefile index 0fb4f94a68857..71c313b90a2b5 100644 --- a/Makefile +++ b/Makefile @@ -952,7 +952,6 @@ KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation) # We'll want to enable this eventually, but it's not going away for 5.7 at least KBUILD_CFLAGS += $(call cc-disable-warning, zero-length-bounds) -KBUILD_CFLAGS += -Wno-array-bounds KBUILD_CFLAGS += $(call cc-disable-warning, stringop-overflow) # Another good warning that we'll want to enable eventually |