diff options
| author | Heinz Mauelshagen <heinzm@redhat.com> | 2016-04-29 18:59:56 +0200 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2016-04-29 15:22:26 -0400 |
| commit | ecdb57d205b98b656ab3ea0412f7a15ec003357f (patch) | |
| tree | f37c01d5976525f2beec2897d3d23b8948184571 | |
| parent | 0222c76e96163355620224625c1cd80991086dc7 (diff) | |
| download | linux-dm-ecdb57d205b98b656ab3ea0412f7a15ec003357f.tar.gz | |
dm raid: make sure no feature flags are set in metadata
Notice: this object is not reachable from any branch.
Given we don't yet support any feature flags in the dm-raid ondisk
metadata (see: 'features' member of 'struct dm_raid_superblock'),
add a check to ensure no flags are actually set, if any features are
set reject the activation of the RAID mapping.
This is to prevent possible data corruption in case of a kernel
downgrade when there'll potentially be feature flags set by a future
dm-raid target.
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Notice: this object is not reachable from any branch.
| -rw-r--r-- | drivers/md/dm-raid.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index a0901214aef57..b65baa0898bc7 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1037,6 +1037,11 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev) if (!mddev->events && super_init_validation(mddev, rdev)) return -EINVAL; + if (le32_to_cpu(sb->features)) { + rs->ti->error = "Unable to assemble array: No feature flags supported yet"; + return -EINVAL; + } + /* Enable bitmap creation for RAID levels != 0 */ mddev->bitmap_info.offset = (rs->raid_type->level) ? to_sector(4096) : 0; rdev->mddev->bitmap_info.default_offset = mddev->bitmap_info.offset; |