diff options
| author | Lakshmi Ramasubramanian <nramas@linux.microsoft.com> | 2021-12-09 17:01:21 -0800 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2021-12-13 16:27:57 +0000 |
| commit | 4bfe24b6beb3f2d9426f8ee7b1946dc967a9d0a9 (patch) | |
| tree | 7668ec8e9801fb2410f4b673cf773a749b3b6e1c | |
| parent | a6a6b9aa34e5701c24661da6af3613f10ea2ec4b (diff) | |
| download | linux-4bfe24b6beb3.tar.gz | |
arm64: kexec: Fix missing error code 'ret' warning in load_other_segments()
Notice: this object is not reachable from any branch.
Since commit ac10be5cdbfa ("arm64: Use common
of_kexec_alloc_and_setup_fdt()"), smatch reports the following warning:
arch/arm64/kernel/machine_kexec_file.c:152 load_other_segments()
warn: missing error code 'ret'
Return code is not set to an error code in load_other_segments() when
of_kexec_alloc_and_setup_fdt() call returns a NULL dtb. This results
in status success (return code set to 0) being returned from
load_other_segments().
Set return code to -EINVAL if of_kexec_alloc_and_setup_fdt() returns
NULL dtb.
Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: ac10be5cdbfa ("arm64: Use common of_kexec_alloc_and_setup_fdt()")
Link: https://lore.kernel.org/r/20211210010121.101823-1-nramas@linux.microsoft.com
Signed-off-by: Will Deacon <will@kernel.org>
Notice: this object is not reachable from any branch.
| -rw-r--r-- | arch/arm64/kernel/machine_kexec_file.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c index 63634b4d72c15..59c648d518488 100644 --- a/arch/arm64/kernel/machine_kexec_file.c +++ b/arch/arm64/kernel/machine_kexec_file.c @@ -149,6 +149,7 @@ int load_other_segments(struct kimage *image, initrd_len, cmdline, 0); if (!dtb) { pr_err("Preparing for new dtb failed\n"); + ret = -EINVAL; goto out_err; } |